Replies: 1 comment 9 replies
-
|
It depends. If it requires FA to take additional dependencies. But maybe it would be a better fit for https://github.com/fluentassertions/fluentassertions.aspnetcore.mvc cc @kevinkuszyk |
Beta Was this translation helpful? Give feedback.
-
|
fluentassertions.aspnetcore.mvc deals specifically with the asp.net core classes like action result so it depends on these libs. This seems more like a separate thing. |
Beta Was this translation helpful? Give feedback.
-
|
Meaning that you would see the proposed assertions for |
Beta Was this translation helpful? Give feedback.
-
|
I see two problems with it: |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, you're right. So I think it's fine to add them to our core library after all. |
Beta Was this translation helpful? Give feedback.
-
|
Okay guys, thank you for the positive discussion :) so I will provide a PR with my existing assertions. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I'm using Fluent Assertions for the integration / E2E tests of my web API as well. So I have a couple of assertions which look like
response.StatusCode.Should().Be(HttpStatusCode.Ok).What do you think about some assertions for
StatusCodeonHttpResponseMessagelike:BeSuccessStatusCode()BeFailedStatusCode()BeStatusCode(HttpStatusCode expectedStatusCode)If you like the idea, I'd love to provide a PR.
Beta Was this translation helpful? Give feedback.
All reactions