Skip to content

1.0: in_tail: Add read_bytes_limit_per_second description#259

Merged
ashie merged 1 commit into
1.0from
1.0-in_tail-read_bytes_limit_per_second
May 29, 2021
Merged

1.0: in_tail: Add read_bytes_limit_per_second description#259
ashie merged 1 commit into
1.0from
1.0-in_tail-read_bytes_limit_per_second

Conversation

@cosmo0920

Copy link
Copy Markdown
Contributor

Documentation for fluent/fluentd#3185.

Signed-off-by: Hiroshi Hatake hatake@clear-code.com

@ashie

ashie commented Mar 2, 2021

Copy link
Copy Markdown
Member

Could you resolve the conflict?

@cosmo0920 cosmo0920 force-pushed the 1.0-in_tail-read_bytes_limit_per_second branch from e02f578 to 498d3a1 Compare March 3, 2021 01:13
@cosmo0920

Copy link
Copy Markdown
Contributor Author

I'd resolved the conflict but this parameter is not supported for now.
We should merge this PR after fluent/fluentd#3185 is merged.

@ashie ashie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the range of read_bytes_limit_per_second should be described (>= 8192)
  • max_thread_pool_size should be added too

Comment thread input/tail.md Outdated
@cosmo0920 cosmo0920 force-pushed the 1.0-in_tail-read_bytes_limit_per_second branch from 498d3a1 to 08df02e Compare May 11, 2021 05:21
Comment thread input/tail.md Outdated
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920 cosmo0920 force-pushed the 1.0-in_tail-read_bytes_limit_per_second branch from 08df02e to 35a7277 Compare May 11, 2021 07:09
@ashie

ashie commented May 13, 2021

Copy link
Copy Markdown
Member

I'll merge it after v1.13 is released.

@ashie ashie merged commit 788ce10 into 1.0 May 29, 2021
@ashie ashie deleted the 1.0-in_tail-read_bytes_limit_per_second branch May 29, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants