CI: Use fiddle 1.0.8 for Ruby 3.0 on Windows#3392
Merged
Merged
Conversation
On Ruby 3.0, we need to use fiddle 1.0.8 or later to retrieve correct error code. In addition, we have to specify the path of fiddle by RUBYLIB because RubyInstaller loads Ruby's bundled fiddle before initializing gem. See also: * ruby/fiddle#72 * https://bugs.ruby-lang.org/issues/17813 * https://github.com/oneclick/rubyinstaller2/blob/8225034c22152d8195bc0aabc42a956c79d6c712/lib/ruby_installer/build/dll_directory.rb Fix fluent#3263 Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Contributor
|
I'll check it. |
kenhys
reviewed
May 25, 2021
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Member
Author
|
Passed on Ruby 3.0.1 on Windows ㊗️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #3263
What this PR does / why we need it:
On Ruby 3.0, we need to use fiddle 1.0.8 or later to retrieve correct
error code. In addition, we have to specify the path of fiddle by RUBYLIB
because RubyInstaller loads Ruby's bundled fiddle before initializing gem.
See also:
Docs Changes:
none
Release Note:
none