WindowsFile: Show the path when Win32Error is occured#3329
Merged
Conversation
In fluent#3325 we added Win32Error to show Windows specific errors correctly, but it's not enough for debugging because it doesn't show which file causes the error. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
cosmo0920
approved these changes
Apr 13, 2021
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
Looks attractive for me.
Member
Author
|
Hmm, it's still not enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
In #3325 we added Win32Error to show Windows specific errors correctly,
but it's not enough for debugging because it doesn't show which file
causes the error.
Docs Changes:
none
Release Note:
none, same with #3325