Added support to use imagePullSecrets defined in values.yaml file#91
Closed
navneet066 wants to merge 3 commits into
Closed
Added support to use imagePullSecrets defined in values.yaml file#91navneet066 wants to merge 3 commits into
navneet066 wants to merge 3 commits into
Conversation
Member
|
@navneet066 Thanks for the PR. Would you please squash your commits into one? |
wanjunlei
reviewed
Jul 16, 2021
| - name: env | ||
| mountPath: /fluentbit-operator | ||
| serviceAccountName: fluentbit-operator | ||
| {{- if .Values.imagePullSecrets }} |
Collaborator
There was a problem hiding this comment.
This format will be less readable, the following format will be better.
serviceAccountName: fluentbit-operator
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 8 }}
{{- end }}
wanjunlei
approved these changes
Jul 16, 2021
wenchajun
approved these changes
Jul 16, 2021
Member
|
@navneet066 Would you please squash your 5 commits into one using cmd like |
Signed-off-by: wenchajun <dehaocheng@yunify.com>
Contributor
Author
|
Hi Everyone, Something wrong with my git. I am closing this one and will create the same with the new PR . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in fluentbit-operator deployment file, there was no support for the imagePullSecrets though it was available in values.yaml file. I will add in other templates also