added support to use resources defined in values file#82
Conversation
in the current version, This is using the hardcoded values of resources here in this file. Calling the values of `resources` defined on the values.yaml file to the `fluentbit-operator-deployment.yaml`
|
@navneet066 Thanks for the PR, the resources in values are for the fluentbit daemonset. |
|
I see. I think we should have the flexibility to modify resources for the operator also. If you are agreeing to this, we can add the resources section for |
|
The resources consumed by the operator usually keep consistent actually, so it's ok to use default values for that. The values could be adjust like below: |
|
Yes. Usually, it is really low. But when the number of nodes in the K8S is high, say 100 or so, It may generate more pressure on the |
the fluentbit-operator just needs to reconcile several crds like FluentBit FluentBitConfig Input parser filter and output no matter how many nodes there actually. Yes, you can add this to values and update the PR |
|
Made the corresponding changes @benjaminhuo . Please have a review and let me know if any other changes are required |
|
@wanjunlei @wenchajun Please help to review this |
|
Maybe you should check the format,such as resources (fluentbit-operator-deployment.yaml), fluentbit.resources.limit (values.yaml ). Please modify its format. Two spaces may be better. |
|
Thank you for your suggestion @wenchajun . I updated the changes as per your comment. |
|
Thanks a lot. But there's still something wrong here. You can learn more about the toyaml function. such as operator.requests (chart/fluentbit-operator/values.yaml). It is wrong. |
| requests: | ||
| cpu: 100m | ||
| memory: 20Mi | ||
| {{ toYaml .Values.resources.operator | indent 12 }} |
There was a problem hiding this comment.
Maybe {{ toYaml .Values.resources.operator.resources | nindent 10 }} is better.
| path: /var/lib/fluent-bit/ | ||
| resources: | ||
| {{- toYaml .Values.resources | nindent 4 }} | ||
| {{- toYaml .Values.resources.fluentbit | nindent 4 }} |
There was a problem hiding this comment.
This line may need to be modified
| memory: 50Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 20Mi |
|
@wenchajun I have made the changes as per the review. Sorry for the iterations. It should be fine now |
in the current version, This is using the hardcoded values of resources here in this file. Calling the values of
resourcesdefined on the values.yaml file to thefluentbit-operator-deployment.yaml