Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 20, 2023

Change Log

Added

Fixed

Changed

Removed

  • Remove `from*` methods from scalar entry classes

Deprecated

Security


Description

Those methods were used only in tests, while we provide more proper usage for creating those entries using DSL functions.

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.748mb -0.01%  | 1.147s -0.30%    | ±0.43% -18.26%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.605mb -0.03%   | 303.538ms -0.02% | ±0.96% -57.72%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.772mb -0.05%   | 1.386s -0.80%    | ±0.14% -85.83%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.476mb -0.00% | 1.590s +0.34%    | ±0.56% +113.04% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.558mb +0.01%   | 24.836ms +2.54%  | ±2.11% -27.34%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.558mb +0.01%   | 403.687ms -0.75% | ±0.21% -50.63%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.249mb -0.00% | 67.054ms +3.67% | ±2.27% +3.27% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.728mb -0.00%  | 451.676ms +1.79% | ±1.10% +133.55% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.711mb -0.00%  | 70.886ms +0.43%  | ±0.19% -85.34%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.311mb -0.00% | 55.934ms +0.57%  | ±0.53% -15.65%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.783mb -0.00% | 1.423s -1.05%    | ±0.26% -47.92%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.589mb -0.01%  | 41.636ms +2.50%  | ±0.94% -23.29%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.296mb -0.01%  | 2.263ms -5.42%   | ±0.68% -80.50%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.086mb -0.00%  | 187.913ms +3.47% | ±0.80% -10.16%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.612mb -0.01%  | 18.582ms +2.25%  | ±0.36% -88.61%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 75.434mb -0.01%  | 1.619ms -3.81%   | ±1.33% -33.35%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 75.434mb -0.01%  | 1.612ms -6.82%   | ±1.78% -20.68%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.648mb -0.01%  | 2.543ms -2.38%   | ±2.92% +120.33%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.177mb -0.01%  | 13.866ms -0.84%  | ±0.61% -28.81%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.176mb -0.01%  | 14.297ms +2.83%  | ±0.38% -77.00%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.079mb -0.01%  | 1.894μs 0.00%    | ±2.53% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.079mb -0.01%  | 0.300μs -25.00%  | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.638mb -0.01%  | 12.742ms -3.78%  | ±0.25% -92.61%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 115.995mb -0.00% | 67.524ms +1.13%  | ±2.35% +273.40%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.697mb -0.01%  | 1.790ms -5.71%   | ±2.15% -0.09%    |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.965mb -0.01%  | 32.534ms -2.60%  | ±0.45% +1168.57% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.798mb -0.01%  | 4.455ms +1.13%   | ±1.96% +92.17%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.222mb -0.01%  | 38.294ms +0.54%  | ±0.57% -10.68%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.223mb -0.01%  | 38.859ms -1.68%  | ±1.18% +0.61%    |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.222mb -0.01%  | 38.597ms +0.13%  | ±0.92% +170.18%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.522mb -0.01%  | 7.392ms +2.01%   | ±0.78% +194.52%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.079mb -0.01%  | 28.983ms +0.53%  | ±0.47% -52.82%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.079mb -0.01%  | 12.779μs -4.78%  | ±0.97% +4.16%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.079mb -0.01%  | 15.372μs -1.96%  | ±3.06% +286.05%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.087mb -0.00%  | 189.421ms +3.48% | ±0.63% +44.83%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.842mb -0.01% | 772.639ms +1.49% | ±0.26% -80.00%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.560mb -0.01%  | 379.432ms -2.76% | ±0.42% -12.85%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.682mb -0.04%  | 79.119ms -0.63%  | ±1.76% +59.17%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@stloyd stloyd merged commit 5fe5631 into flow-php:1.x Nov 20, 2023
@stloyd stloyd deleted the chore/remove-from-scalar branch November 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants