Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Fixed snappy warnings

Changed

Removed

Deprecated

Security


Description

Closes: #722

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.233mb -0.00%  | 439.423ms -16.40% | ±0.37% -16.34%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.791mb +0.01%   | 338.382ms -18.52% | ±0.38% -84.59%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.950mb +0.01%   | 654.725ms -21.70% | ±0.60% +179.09% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.539mb +0.00% | 944.450ms -19.15% | ±0.27% -6.68%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.785mb +0.01%   | 24.702ms -9.88%   | ±0.68% +62.57%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.785mb +0.01%   | 518.287ms -22.28% | ±0.16% -70.94%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.052mb +0.00% | 62.147ms -20.26% | ±1.02% +62.74% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.423mb +0.00%  | 663.962ms -20.80% | ±0.24% -71.74%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.068mb +0.00%  | 70.192ms -14.50%  | ±0.26% -50.53%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 89.701mb +0.00%  | 70.420ms -22.65%  | ±1.26% +396.48% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 285.172mb +0.00% | 1.552s -18.78%    | ±0.08% -89.62%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.562mb +0.00%  | 35.153ms -15.39%  | ±0.41% -75.99%  |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev          |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.661mb +0.00% | 3.287ms -42.68%   | ±0.77% -63.27%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.453mb +0.00% | 175.837ms -18.53% | ±0.13% -79.45%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.979mb +0.00% | 17.818ms -18.73%  | ±0.73% -1.27%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.800mb +0.00% | 2.715ms -31.11%   | ±0.44% -87.11%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.800mb +0.00% | 2.648ms -32.87%   | ±0.77% -49.90%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.013mb +0.00% | 3.706ms -27.13%   | ±0.44% -77.16%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.542mb +0.00% | 17.519ms -34.72%  | ±1.11% +197.09% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.542mb +0.00% | 17.291ms -34.79%  | ±0.47% -10.09%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.613mb +0.00% | 2.300μs -11.96%   | ±3.55% +0.41%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.613mb +0.00% | 0.500μs 0.00%     | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.846mb +0.00% | 13.732ms -18.19%  | ±2.47% +512.59% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.366mb +0.00% | 57.017ms -22.14%  | ±1.09% +185.07% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.063mb +0.00% | 2.879ms -32.12%   | ±1.50% +5.58%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.333mb +0.00% | 40.534ms -30.41%  | ±0.96% +119.95% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.163mb +0.00% | 7.011ms -33.40%   | ±1.58% +115.28% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.613mb +0.00% | 45.861ms -26.30%  | ±0.20% -65.64%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.613mb +0.00% | 45.734ms -26.14%  | ±0.10% -90.22%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.613mb +0.00% | 46.263ms -25.07%  | ±0.15% -58.90%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.887mb +0.00% | 9.877ms -12.93%   | ±2.01% +79.35%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.612mb +0.00% | 36.253ms -22.74%  | ±0.09% -89.28%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.613mb +0.00% | 20.518μs -20.47%  | ±0.69% +116.93% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.613mb +0.00% | 26.200μs -18.33%  | ±0.00% -100.00% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.454mb +0.00% | 179.892ms -17.28% | ±0.88% -23.79%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 92.858mb +0.00% | 147.813ms -17.85% | ±0.55% +39.93%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 48.174mb +0.01% | 74.427ms -18.43%  | ±0.27% -38.44%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.515mb +0.01% | 17.943ms -17.60%  | ±0.48% -34.16%  |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+

@norberttech norberttech merged commit 34d6be4 into flow-php:1.x Nov 7, 2023
@norberttech norberttech deleted the bug/snappy-compression-warnings branch December 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snappy & Parquet tests can throw warnings randomly

2 participants