Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Oct 28, 2023

Change Log

Added

Fixed

  • Prevent fatal error when no values are set in `ColumnChunkStatistics`

Changed

Removed

Deprecated

Security


Description

Code borrowed from: #653

Error:

Fatal error: Uncaught DivisionByZeroError: Division by zero in /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkStatistics.php:71
Stack trace:
#0 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/PagesBuilder.php(25): Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkStatistics->cardinalityRation()
#1 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkBuilder.php(34): Flow\Parquet\ParquetFile\RowGroupBuilder\PagesBuilder->build(Object(Flow\Parquet\ParquetFile\Schema\FlatColumn), Array, Object(Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkStatistics))
#2 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder.php(63): Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkBuilder->flush(4)
#3 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/Writer.php(59): Flow\Parquet\ParquetFile\RowGroupBuilder->flush(4)
#4 /Users/stloyd/Documents/flow/var/profile.php(65): Flow\Parquet\Writer->write('/Users/stloyd/D...', Object(Flow\Parquet\ParquetFile\Schema), Array)
#5 {main}
  thrown in /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkStatistics.php on line 71

@stloyd stloyd force-pushed the chore/parq-chunk-stat branch from 31c1055 to 6f325c6 Compare October 28, 2023 18:07
@stloyd stloyd requested a review from norberttech October 28, 2023 18:13
@norberttech norberttech merged commit 2dbbfa2 into flow-php:1.x Oct 29, 2023
@stloyd stloyd deleted the chore/parq-chunk-stat branch October 29, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants