Parquet page viewer #644
Merged
Parquet page viewer #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
reviewed
Oct 25, 2023
| \fseek($stream, $pageOffset); | ||
| $thriftHeader = new \Flow\Parquet\Thrift\PageHeader(); | ||
| $thriftHeader->read(new TCompactProtocol(new TBufferedTransport(new TPhpFileStream($stream)))); | ||
| @$thriftHeader->read(new TCompactProtocol(new TBufferedTransport(new TPhpFileStream($stream)))); |
Member
There was a problem hiding this comment.
What error you have silenced here?
Member
Author
There was a problem hiding this comment.
internal thrift warning about invalid array offset, unrelated for the logic, annoying in the CLI
stloyd
reviewed
Oct 25, 2023
Comment on lines
+59
to
+60
| \strlen($pageContainer->pageDataBuffer) + \strlen($pageContainer->pageHeaderBuffer), | ||
| \strlen($pageContainer->pageDataBuffer) + \strlen($pageContainer->pageHeaderBuffer), |
Member
There was a problem hiding this comment.
As this is repeated, it can be extracted.
Member
Author
There was a problem hiding this comment.
this is a temporary hack. One is compressed, another uncompressed size, once I move to compressions this will be changed, but I'm leaving compressions for the end, now I'm going to tackle encodings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Ref: #575
Even though this is not mandatory for the reader itself, I'm going to use it later for parquet viewer CLI app, for now I'm using this to quickly understand parquet files.
This is how the viewer might look like in the future:
