Skip to content

New PHAR build #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 3 commits into from
Oct 2, 2023
Merged

New PHAR build #477

norberttech merged 3 commits into from
Oct 2, 2023

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Sep 7, 2023 •
edited
Loading

Change Log

Added

  • Added new Phar module that generates Flow-PHP phar file

Fixed

Changed

Removed

Deprecated

Security

Description

Phar

  1. Update dependencies: composer install,
  2. Run the compilation step (be sure you have a phar extension enabled in your PHP binary): composer build:compile,
  3. Test adjusted example with brand new phar: ./flow-php.phar examples/topics/aggregations/power_plant.php

Expected result:

+---------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+-------------+
|    date | production_kwh_avg | consumption_kwh_avg | production_kwh_min | consumption_kwh_min | production_kwh_max | consumption_kwh_max | production_kwh_sum | consumption_kwh_sum | consumption |
+---------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+-------------+
| 2022/01 |              12.54 |               16.94 |               2.11 |               12.65 |              37.34 |               23.36 |             388.66 |               525.2 |     135.13% |
| 2022/02 |               24.5 |               17.75 |               5.41 |               14.76 |              48.16 |               29.04 |             685.93 |              497.11 |      72.47% |
| 2022/03 |              44.71 |               16.48 |               4.73 |               12.15 |              63.89 |               21.69 |            1386.03 |              510.81 |      36.85% |
| 2022/04 |              32.03 |               14.72 |               1.26 |                 3.5 |              57.02 |               22.11 |             448.42 |              206.09 |      45.96% |
+---------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+--------------------+---------------------+-------------+
4 rows
stloyd@MacBook-Pro-2 flow % ./flow-php.phar --version
Flow-PHP - Extract Transform Load - Data processing framework 1.0.x-02fba709

@stloyd stloyd changed the title PoC - New phar module PoC - New phar build Sep 7, 2023
@github-actions github-actions bot removed the ci/cd label Sep 7, 2023
@github-actions github-actions bot added the ci/cd label Sep 10, 2023
@stloyd stloyd changed the title PoC - New phar build New executable binary build Sep 19, 2023
@stloyd stloyd marked this pull request as ready for review September 19, 2023 10:09
stloyd
stloyd commented Sep 19, 2023
View reviewed changes
stloyd
stloyd commented Sep 19, 2023
View reviewed changes
norberttech
norberttech reviewed Sep 19, 2023
View reviewed changes
norberttech
norberttech reviewed Sep 19, 2023
View reviewed changes
norberttech
norberttech reviewed Sep 19, 2023
View reviewed changes
@norberttech
Copy link
Member

norberttech commented Sep 19, 2023

is there a way to reproduce the same process from github actions workflow locally without using act to emulate actions?

@stloyd
Copy link
Member Author

stloyd commented Sep 19, 2023

Added notes to the description, should be enough to generate the binary locally.

@norberttech
Copy link
Member

norberttech commented Sep 19, 2023

Added notes to the description, should be enough to generate the binary locally.

I can't see it, did you maybe forgot to push the commit?

norberttech
norberttech reviewed Sep 20, 2023
View reviewed changes
@stloyd stloyd force-pushed the phar-module branch 2 times, most recently from 858fb40 to eb1bd23 Compare October 1, 2023 09:44
@github-actions github-actions bot removed the examples label Oct 1, 2023
@stloyd stloyd changed the title New executable binary build New PHAR build Oct 1, 2023
@stloyd stloyd requested a review from norberttech October 1, 2023 09:51
@stloyd stloyd force-pushed the phar-module branch 3 times, most recently from a17a60b to 1d78bbd Compare October 1, 2023 14:02
@norberttech norberttech enabled auto-merge (squash) October 2, 2023 10:31
@norberttech norberttech merged commit 98aecbc into flow-php:1.x Oct 2, 2023
@stloyd stloyd deleted the phar-module branch October 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norberttech norberttech Awaiting requested review from norberttech norberttech is a code owner

Assignees

No one assigned

Labels

size: M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stloyd @norberttech