Skip to content

Adjust Parameter::asNumber() behaviour to match closer the PHP one #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 1 commit into from
Jan 11, 2026
Merged

Adjust Parameter::asNumber() behaviour to match closer the PHP one #2143

norberttech merged 1 commit into from
Jan 11, 2026

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Jan 11, 2026

Resolves: #2142

Change Log

Added

Fixed

Changed

  • Adjust `Parameter::asNumber()` behaviour to match closer the PHP one

Removed

Deprecated

Security

@codecov
Copy link

codecov bot commented Jan 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (d14d490) to head (6a058e6).
⚠️ Report is 2 commits behind head on 1.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##              1.x    #2143      +/-   ##
==========================================
+ Coverage   83.09%   83.33%   +0.24%     
==========================================
  Files        1178     1178              
  Lines       42158    42164       +6     
==========================================
+ Hits        35030    35138     +108     
+ Misses       7128     7026     -102
Components Coverage Δ
etl 90.55% <100.00%> (+0.89%) ⬆️
cli 85.76% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.16% <ø> (ø)
lib-filesystem 80.44% <ø> (ø)
lib-types 88.98% <ø> (+1.51%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
bridge-filesystem-async-aws 90.95% <ø> (ø)
bridge-filesystem-azure 89.38% <ø> (ø)
bridge-monolog-http 96.89% <ø> (ø)
bridge-openapi-specification 91.50% <ø> (ø)
symfony-http-foundation 74.11% <ø> (ø)
adapter-chartjs 86.33% <ø> (ø)
adapter-csv 89.30% <ø> (ø)
adapter-doctrine 92.00% <ø> (ø)
adapter-elasticsearch 97.02% <ø> (ø)
adapter-google-sheet 97.05% <ø> (ø)
adapter-http 65.94% <ø> (ø)
adapter-json 89.69% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.77% <ø> (ø)
adapter-parquet 79.92% <ø> (ø)
adapter-text 86.84% <ø> (ø)
adapter-xml 82.66% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stloyd stloyd marked this pull request as ready for review January 11, 2026 10:18
@stloyd stloyd requested a review from norberttech as a code owner January 11, 2026 10:18
@norberttech norberttech merged commit 42538b8 into flow-php:1.x Jan 11, 2026
23 checks passed
@stloyd stloyd deleted the feature/2142 branch January 11, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norberttech norberttech Awaiting requested review from norberttech norberttech is a code owner

Assignees

No one assigned

Labels

size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Parameter::asNumber() doesn't work with string

2 participants

@stloyd @norberttech