Skip to content

Remove Rows::fromArray(), pass EntryFactory to the join methods #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 3 commits into from
Oct 28, 2025
Merged

Remove Rows::fromArray(), pass EntryFactory to the join methods #1929

norberttech merged 3 commits into from
Oct 28, 2025

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Oct 28, 2025 •
edited
Loading

Resolves: #1928

Change Log

Added

Fixed

Changed

  • Pass `EntryFactory` to the `Rows::join*()` methods
  • Enforce instance of EntryFactory in the join methods

Removed

  • Remove `Rows::fromArray()`

Deprecated

Security

@stloyd stloyd requested a review from norberttech as a code owner October 28, 2025 15:48
norberttech
norberttech reviewed Oct 28, 2025
View reviewed changes
@stloyd stloyd requested a review from norberttech October 28, 2025 16:55
@codecov
Copy link

codecov bot commented Oct 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.28%. Comparing base (a357ee4) to head (2a590ea).
⚠️ Report is 2 commits behind head on 1.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              1.x    #1929   +/-   ##
=======================================
  Coverage   77.28%   77.28%           
=======================================
  Files         829      829           
  Lines       24613    24609    -4     
=======================================
- Hits        19021    19019    -2     
+ Misses       5592     5590    -2
Components Coverage Δ
etl 88.82% <100.00%> (+0.02%) ⬆️
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.08% <ø> (ø)
lib-types 53.56% <ø> (ø)
lib-parquet 68.34% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
bridge-filesystem-async-aws 90.16% <ø> (ø)
bridge-filesystem-azure 89.47% <ø> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <ø> (ø)
adapter-csv 88.46% <ø> (ø)
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 87.74% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.15% <ø> (ø)
adapter-text 82.92% <ø> (ø)
adapter-xml 82.50% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 6b50249 into flow-php:1.x Oct 28, 2025
19 checks passed
@stloyd stloyd deleted the bugfix/1928-cleanup branch October 28, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norberttech norberttech norberttech approved these changes

Assignees

No one assigned

Labels

size: S size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal]: Remove Rows::fromArray() helper (syntax-sugar?)

2 participants

@stloyd @norberttech