Rework RenameReplaceEntryStrategy to allow multiple strings
#1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86d5767 to
2249cbd
Compare
norberttech
approved these changes
May 7, 2025
auto-merge was automatically disabled
May 7, 2025 12:13
Head branch was pushed to by a user without write access
Contributor
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.888mb +0.01% | 623.025ms +1.66% | ±0.73% -58.16% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 5.468mb +0.03% | 1.336s -0.57% | ±0.23% -12.04% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 86.485mb +0.00% | 923.412ms -0.88% | ±1.96% +249.42% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.612mb +0.01% | 38.954ms -0.03% | ±0.25% -19.20% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.586mb +0.01% | 610.420ms +1.61% | ±0.49% +34.25% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 127.409mb +0.00% | 68.324ms -0.80% | ±3.18% +211.54% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench | bench_load_10k | 1 | 3 | 64.055mb +0.00% | 103.660ms -0.70% | ±0.75% -17.80% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 84.087mb +0.00% | 95.459ms -1.57% | ±2.01% +72.09% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 166.569mb +0.00% | 20.617s -0.38% | ±0.62% +258.82% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 18.144mb +0.00% | 30.816ms +0.17% | ±1.56% +149.57% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| TypeDetectorBench | bench_type_detector | 1 | 3 | 44.053mb +0.00% | 458.930ms -1.87% | ±0.78% -16.38% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 11.862mb +0.00% | 92.684ms -0.97% | ±1.11% +22.16% |
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 97.072mb +0.00% | 3.336ms -3.69% | ±1.36% -49.27% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 114.428mb +0.00% | 180.353ms -2.54% | ±1.69% +96.52% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 97.148mb +0.00% | 18.125ms -2.98% | ±2.08% +316.65% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 97.946mb +0.00% | 1.533ms +0.76% | ±1.38% -31.47% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 97.946mb +0.00% | 1.620ms +2.87% | ±2.20% -24.54% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 96.107mb +0.00% | 4.353ms +0.40% | ±1.54% -14.55% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 96.636mb +0.00% | 16.088ms -0.89% | ±1.09% +68.87% |
| RowsBench | bench_find_on_10k | 2 | 3 | 96.636mb +0.00% | 16.029ms -2.71% | ±1.20% +6.86% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 95.327mb +0.00% | 1.894μs +4.87% | ±2.53% -1.79% |
| RowsBench | bench_first_on_10k | 10 | 3 | 95.327mb +0.00% | 0.200μs -50.00% | ±0.00% 0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 104.545mb +0.00% | 14.741ms -4.27% | ±0.19% -91.49% |
| RowsBench | bench_map_on_10k | 2 | 3 | 134.613mb +0.00% | 70.460ms -0.72% | ±1.15% +90.33% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 97.156mb +0.00% | 1.434ms +3.30% | ±1.50% +39.94% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 100.527mb +0.00% | 63.271ms +1.89% | ±1.00% +54.21% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 98.208mb +0.00% | 3.811ms +2.95% | ±1.08% +14.15% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 95.690mb +0.00% | 40.412ms -1.32% | ±0.72% -52.42% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 95.690mb +0.00% | 40.044ms -1.10% | ±0.46% +7.19% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 95.690mb +0.00% | 39.650ms -0.87% | ±2.04% -11.96% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 97.768mb +0.00% | 8.234ms +0.57% | ±3.22% +2143.65% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 95.518mb +0.00% | 29.908ms +1.80% | ±0.75% -52.93% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 95.327mb +0.00% | 13.312μs -13.13% | ±0.71% -77.83% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 95.327mb +0.00% | 15.566μs -3.13% | ±2.73% +84.85% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 114.429mb +0.00% | 184.497ms -2.32% | ±0.82% +107.85% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 105.518mb +0.00% | 724.314ms +0.54% | ±0.76% +230.24% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 55.028mb +0.00% | 358.986ms -1.94% | ±0.86% +107.01% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 14.806mb +0.00% | 77.577ms -1.19% | ±1.27% +35.07% |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1633 +/- ##
==========================================
- Coverage 83.18% 83.17% -0.02%
==========================================
Files 706 706
Lines 19100 19100
==========================================
- Hits 15889 15886 -3
- Misses 3211 3214 +3
🚀 New features to boost your workflow:
|
norberttech
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description