Skip to content

Fixed renaming functionality to work with i18n characters #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 1 commit into from
Apr 28, 2025
Merged

Fixed renaming functionality to work with i18n characters #1607

norberttech merged 1 commit into from
Apr 28, 2025

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Apr 28, 2025

Change Log

Added

Fixed

  • Fixed renaming functionality to work with i18n characters

Changed

Removed

Deprecated

Security

Description

@stloyd stloyd requested a review from norberttech as a code owner April 28, 2025 09:20
@norberttech norberttech enabled auto-merge (squash) April 28, 2025 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors 
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.882mb +0.00%  | 613.499ms -0.69% | ±0.28% -33.81% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.467mb +0.04%  | 1.352s +1.09%    | ±0.28% -14.49% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.479mb +0.00% | 923.539ms -0.11% | ±0.11% -66.33% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.606mb +0.00%  | 38.891ms +1.11%  | ±0.86% +58.66% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.581mb +0.00%  | 602.561ms +0.42% | ±0.70% -17.10% |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
Transformers 
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.404mb +0.00% | 69.614ms -0.86% | ±0.84% -0.85% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders 
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.049mb +0.00%  | 102.687ms -2.29% | ±0.07% -94.08%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.081mb +0.00%  | 99.381ms +3.65%  | ±2.36% +416.04% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.563mb +0.00% | 20.642s -1.06%   | ±0.18% -55.10%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.139mb +0.00%  | 30.868ms -0.41%  | ±0.21% -35.88%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks 
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.066mb +0.00%  | 3.268ms +5.11%   | ±2.25% +68.39%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.422mb +0.00% | 183.348ms -1.14% | ±0.36% -43.06%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.142mb +0.00%  | 18.447ms -0.41%  | ±0.51% +5.65%   |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.941mb +0.00%  | 1.457ms -1.33%   | ±2.90% +87.05%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.941mb +0.00%  | 1.433ms -10.24%  | ±1.67% -33.57%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.101mb +0.00%  | 4.298ms -3.04%   | ±3.41% +20.38%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.630mb +0.00%  | 16.290ms -9.93%  | ±0.69% +83.00%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.630mb +0.00%  | 16.415ms -9.66%  | ±0.71% -24.68%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.322mb +0.00%  | 1.794μs 0.00%    | ±2.67% 0.00%    |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.322mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.540mb +0.00% | 14.672ms -3.19%  | ±0.45% -50.29%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.607mb +0.00% | 69.285ms -4.58%  | ±0.47% -35.22%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.150mb +0.00%  | 1.302ms +0.98%   | ±2.66% +8.98%   |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.522mb +0.00% | 63.609ms +2.52%  | ±0.46% -37.21%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.203mb +0.00%  | 3.792ms +2.46%   | ±0.75% -27.70%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.684mb +0.00%  | 39.873ms +0.14%  | ±0.73% -11.19%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.685mb +0.00%  | 40.045ms -2.90%  | ±0.45% -7.99%   |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.684mb +0.00%  | 40.210ms -2.24%  | ±2.53% +114.89% |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.762mb +0.00%  | 8.199ms -1.03%   | ±0.16% -33.37%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.512mb +0.00%  | 29.636ms -0.36%  | ±1.30% +260.33% |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.322mb +0.00%  | 13.900μs +4.42%  | ±0.59% -16.72%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.322mb +0.00%  | 15.200μs 0.00%   | ±0.54% +0.00%   |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.423mb +0.00% | 185.521ms -0.43% | ±1.37% +283.30% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 44.047mb +0.00%  | 463.141ms +0.13% | ±0.82% +173.39% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.857mb +0.00%  | 92.588ms -0.51%  | ±0.34% -1.07%   |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.512mb +0.00% | 719.375ms -0.47% | ±0.89% -9.76%   |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.022mb +0.00%  | 366.258ms +0.00% | ±0.23% -75.50%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.800mb +0.00%  | 79.618ms +2.19%  | ±1.38% +205.23% |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (4fd67a7) to head (ab5cb8e).
Report is 1 commits behind head on 1.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              1.x    #1607   +/-   ##
=======================================
  Coverage   83.19%   83.20%           
=======================================
  Files         703      703           
  Lines       19037    19053   +16     
=======================================
+ Hits        15838    15853   +15     
- Misses       3199     3200    +1
Components Coverage Δ
etl 86.25% <90.00%> (+<0.01%) ⬆️
cli 84.59% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.36% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.51% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 2cae774 into flow-php:1.x Apr 28, 2025
33 of 34 checks passed
@stloyd stloyd deleted the i18n-renaming branch April 28, 2025 10:05
@norberttech norberttech moved this from Todo to Done in Roadmap Apr 28, 2025
@norberttech norberttech added this to the 0.15.0 milestone Apr 28, 2025
@stloyd stloyd mentioned this pull request May 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norberttech norberttech norberttech approved these changes

Assignees

No one assigned

Labels

size: S

Projects

Roadmap
Archived in project

Milestone

0.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stloyd @norberttech