-
-
Notifications
You must be signed in to change notification settings - Fork 48
Added nix flake for local development #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nix flake for local development #1468
Conversation
|
Since I'm not very advanced with Nix I had to use some help from GitHub Copilot to put those together. @Ocramius @drupol could I bother you to take a look and share some feedback? 🙏 (I don't know anyone else more experienced in nix 😅) Wasn't sure about Also does any of you by any chance know if there is a way to use nix flakes on github actions? That would be pretty amazing to have all php/os dependencies the same between local and ci/cd environments. This PR is not yet ready to be merged, it's missing documentation in
|
https://determinate.systems/posts/nix-github-actions/ - seems to be possible and maybe not even that hard with those two actions |
|
Let me check this out asap. |
|
Looks like it works |
like a charm! Now just need to go through all the new things you introduced and try to understand them 😁 Looks much better than was I had before, thank you! |
|
Hit me if you're blocked, I'll do my best to help. |
|
Cool and fancy stuff, but 1GB for a development shell is way too big for me... but it's up to you. |
|
oh I think its the other software I added, will take a look on the size later and remove few things, you are right, 1gb its a bit too much 😅 thanks! |
|
With experience, the lesser the better when it comes to development shells. |
|
@drupol, are there any best practices around allowing developers to extend the development shell according to their needs? I'm going to remove that tooling as you recommended, but I wonder if there is a way to let people locally add stuff if they want without committing any changes. |
|
heh after removing everything except php and those 4 extensions it's still 1Gb 😅 but I think I'm fine with that, it's not meant for all users, not even for most of the users |
…pport for arguments in flakes
cbdfccf to
8e683f7
Compare


Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Reference: #1467