Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Jan 7, 2025

Change Log

Added

Fixed

  • Structure ignoring wrong element names, not matching type definition

Changed

  • Simplified defining StructureType by removing StructureElement

Removed

  • MapKey
  • MapValue
  • ListElement
  • StructureElemet

Deprecated

Security


Description

Resolves: #1342

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.754mb -0.25%  | 511.932ms -2.32% | ±0.37% -64.77%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.862mb -1.08%  | 1.027s -7.47%    | ±1.79% +48.70%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.499mb -0.04% | 893.708ms -3.11% | ±0.39% +182.19% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.487mb -0.26%  | 32.465ms +0.88%  | ±0.39% -29.81%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.464mb -0.26%  | 585.774ms -0.55% | ±3.28% +474.76% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 108.483mb -0.01% | 57.878ms -1.47% | ±0.49% -77.23% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.029mb -0.02%  | 116.677ms +0.21% | ±1.29% +168.90% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 82.574mb -7.02%  | 105.725ms -1.38% | ±0.28% -50.29%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.996mb -0.02% | 19.148s -3.86%   | ±0.19% -69.29%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.072mb -0.07%  | 44.046ms -0.42%  | ±0.95% +580.21% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 80.258mb -0.01%  | 3.191ms -16.54%  | ±3.23% +124.76% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 97.534mb -0.01%  | 182.758ms +0.93% | ±0.71% +41.29%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 80.254mb -0.01%  | 18.175ms -2.39%  | ±0.18% -0.17%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 81.133mb -0.01%  | 1.540ms -24.44%  | ±4.01% +345.35% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 81.133mb -0.01%  | 1.491ms -23.71%  | ±0.92% -66.61%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 79.294mb -0.01%  | 3.484ms -12.18%  | ±1.91% +801.20% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 79.823mb -0.01%  | 15.103ms -2.44%  | ±0.85% +164.34% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 79.823mb -0.01%  | 15.232ms -1.82%  | ±0.80% +33.47%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 78.514mb -0.02%  | 1.806μs -9.97%   | ±2.57% +10.91%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 78.514mb -0.02%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.851mb -0.01%  | 12.375ms -5.37%  | ±0.30% -79.85%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 114.199mb -0.01% | 58.908ms -4.23%  | ±1.27% -58.36%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 80.343mb -0.01%  | 1.310ms -35.19%  | ±1.50% -57.67%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 83.633mb -0.01%  | 60.383ms -0.53%  | ±0.86% +187.68% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 81.395mb -0.01%  | 3.698ms -11.83%  | ±0.57% -68.00%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 78.795mb -0.01%  | 40.849ms -1.50%  | ±0.44% -48.59%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 78.796mb -0.01%  | 42.107ms -3.89%  | ±1.04% -41.12%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 78.795mb -0.01%  | 40.802ms -1.84%  | ±0.99% -36.83%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 80.955mb -0.01%  | 7.783ms -2.42%   | ±0.53% -7.97%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 78.705mb -0.01%  | 29.871ms -0.04%  | ±1.69% +50.44%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 78.514mb -0.02%  | 13.579μs -8.68%  | ±0.91% -42.82%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 78.514mb -0.02%  | 15.421μs -9.72%  | ±0.81% -75.29%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 97.535mb -0.01%  | 187.858ms +0.94% | ±0.99% +39.72%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 49.240mb -11.11% | 346.019ms -9.47% | ±1.73% +220.91% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 12.808mb -9.57%  | 69.916ms -10.32% | ±0.37% -65.32%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 103.316mb -4.53% | 432.509ms -6.16% | ±0.15% -27.88%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.827mb -4.38%  | 216.848ms -6.78% | ±1.29% +101.63% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.405mb -5.31%  | 47.241ms -9.22%  | ±0.27% -21.06%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 81.18812% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (1eeb7c2) to head (ba1eb0a).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1343      +/-   ##
==========================================
+ Coverage   82.35%   82.58%   +0.23%     
==========================================
  Files         645      641       -4     
  Lines       17436    17290     -146     
==========================================
- Hits        14359    14279      -80     
+ Misses       3077     3011      -66     
Components Coverage Δ
etl 86.00% <95.00%> (+0.66%) ⬆️
cli 85.17% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.60% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.24% <ø> (ø)
lib-parquet 84.16% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 91.24% <ø> (ø)
bridge-filesystem-async-aws 90.60% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.49% <ø> (ø)
adapter-doctrine 90.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 92.85% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 59.88% <44.82%> (-0.87%) ⬇️
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <100.00%> (ø)

@norberttech norberttech merged commit 5758cef into flow-php:1.x Jan 7, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of MapKey/MapValue/ListElement objects

1 participant