Skip to content

[Bug]: Reading CSV with multiline strings #1738

@norberttech

Description

@norberttech

What happened?

Reading CSV files with multiline strings inside of them will fail currently.
The problem comes from here: https://github.com/flow-php/flow/blob/1.x/src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/CSVExtractor.php#L56

How to reproduce?

df()->read(from_csv(__DIR__.'/dataset.csv'))->write(to_output())->run();

Data required to reproduce bug locally

"artist","song","link","text"
"ABBA","Ahe's My Kind Of Girl","/a/abba/ahes+my+kind+of+girl_20598417.html","Look at her face, it's a wonderful face  
And it means something special to me  
Look at the way that she smiles when she sees me  
How lucky can one fellow be?  
  
She's just my kind of girl, she makes me feel fine  
Who could ever believe that she could be mine?  
She's just my kind of girl, without her I'm blue  
And if she ever leaves me what could I do, what could I do?  
  
And when we go for a walk in the park  
And she holds me and squeezes my hand  
We'll go on walking for hours and talking  
About all the things that we plan  
  
She's just my kind of girl, she makes me feel fine  
Who could ever believe that she could be mine?  
She's just my kind of girl, without her I'm blue  
And if she ever leaves me what could I do, what could I do?

"

Version

0.19.0

Relevant error output

Text row is going to be cut to `Look at her face, it's a wonderful face`

Metadata

Metadata

Assignees

Labels

Type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions