✅ Deploy Preview for vibrant-gates-22c214 canceled.

@floating-ui/dom (1.0.12 → 1.1.0)

Refactors

• fix: support cross-document anchoring, where if floating element is in a higher-level window than the reference element, the positioning takes this into account (i.e. reference element is inside an iframe, but the floating element isn't)

  Bumping minor version because if you were adding external code/custom middleware to add support yourself, it will break with this update as it's no longer necessary.

Packages With No Changes

The following packages have no user facing changes, so won't be released:

• @floating-ui/core
• @floating-ui/react
• @floating-ui/react-dom
• @floating-ui/react-native
• @floating-ui/vue

Edit changelogs

Change log has not been updated since latest commit Update Changelog

Hey @atomiks, is this fix already included in the latest version of the @floating-ui/dom package (i.e 1.1.0) ?

I gave it a quick look and it doesn't seem to fix the issues that we were trying to fix in https://github.com/WordPress/gutenberg/

Hey yeah it's in 1.1.0. Can you take a look at the iframe visual tests and see if it's missing a particular case which causes it to not work?

I'm not quite sure — I gave a quick look at the visual tests and they seem comprehensive.

I've opened a draft PR WordPress/gutenberg#46845 to hopefully help debugging what's going on.

Would be open to having a chat so that we can more easily discuss the issue at hand? If so, you can find me on the Make WordPress slack as mciampini — I'd love to collaborate and get to the bottom of the cross-document support feature!

@ciampo yes sure, I'll join soon

Awesome! Cc'ing @jsnajdr who is potentially interested in collaborating on this too.