Add unknown class name to deserialization error#303
Merged
Skn0tt merged 3 commits intoDec 5, 2024
Merged
Conversation
|
This is awesome change, would help debug various issues when deserialization fails when class or other element is not registered or it's module not imported. Would love to have that merged! ❤️ |
Skn0tt
reviewed
Nov 7, 2024
Co-authored-by: Simon Knott <info@simonknott.de>
Contributor
Author
@Skn0tt tried for a while now and I can't seem to make it throw that error in tests, can I get some help with this? :) |
Collaborator
|
Try this: ❯ git diff src
diff --git a/src/index.test.ts b/src/index.test.ts
index e314728..ee49e72 100644
--- a/src/index.test.ts
+++ b/src/index.test.ts
@@ -810,6 +810,9 @@ describe('stringify & parse', () => {
);
expect(deserialized.s7).toBeInstanceOf(Train);
expect(typeof deserialized.s7.brag()).toBe('string');
+
+ meta.values.s7 = [['class', 'Plane']];
+ expect(() => SuperJSON.deserialize(JSON.parse(JSON.stringify({ json, meta })))).toThrowError(`Trying to deserialize unknown class 'Plane' - check https://github.com/blitz-js/superjson/issues/116#issuecomment-773996564`)
});
describe('with accessor attributes', () => { |
Contributor
Author
Thank you, got it working. |
Skn0tt
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test case and improves error messaging in the
SuperJSONdeserialization process. The changes enhance the developer experience by providing more descriptive error messages and ensuring the robustness of the code.Enhancements to error messaging and testing:
src/transformer.ts: Updated the error message to include the name of the unknown class being deserialized, making it easier to identify the issue.src/transformer.test.ts: Added a new test case to verify that an appropriate error is thrown when attempting to deserialize an unregistered class, ensuring that the error message includes missing class name.