bug repro with dedupe=true#253
Merged
Merged
Conversation
Collaborator
|
Finally got around to take a look at this. It was a nifty small bug, definitely a fun sherlocking adventure! :D I put some prose as to what's happening into the test in 593841d, if you're curious. |
Skn0tt
approved these changes
Sep 27, 2023
Skn0tt
left a comment
Collaborator
There was a problem hiding this comment.
The code looks super good. I couldn't have written this better myself, except for the parts I wrote myself.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a bug with dedupe option.
I'm sorry for this repro, it's awful and huge and bloated. Haven't narrowed it down more, but AFAICT, the results of these should be equal but they aren't.
The problem shows in the diff between non-deduped and deduped; some values stay as
nullafter deserializing the deduped one.