fix: TypeError: SuperJSON is not a constructor#250
Merged
Conversation
Contributor
Author
|
Not optimal since it doesn't fix the default import, but works as a workaround 🤷🏼♂️ Tested using |
Merged
Collaborator
|
That's a good workaround, I guess. The problem with the default export boils down to the fact that apparently, import SuperJSON from "superjson"
new SuperJSON.default() |
Collaborator
|
Let's get this merged 🤷 |
Skn0tt
approved these changes
Jul 17, 2023
Contributor
Author
While that might work in runtime, you get typeerrors. Somewhere the type is wrong I guess? Bundlers are weird... 
|
Collaborator
|
Published as part of https://github.com/blitz-js/superjson/releases/tag/v1.13.1. |
Contributor
Author
|
And this errors with the same error: import * as SuperJSON from 'superjson'
export const superjson = new SuperJSON.default({
dedupe: true,
})
|
Contributor
Author
Can confirm it works straight from node_modules (no local linked package) 👍🏼 |
Chia1104
referenced
this pull request
in Chia1104/chia1104.dev
Jul 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [superjson](https://togithub.com/blitz-js/superjson) | [`1.12.4` -> `1.13.1`](https://renovatebot.com/diffs/npm/superjson/1.12.4/1.13.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>blitz-js/superjson (superjson)</summary> ### [`v1.13.1`](https://togithub.com/blitz-js/superjson/releases/tag/v1.13.1) [Compare Source](https://togithub.com/blitz-js/superjson/compare/v1.13.0...v1.13.1) #### What's Changed - Bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/218](https://togithub.com/blitz-js/superjson/pull/218) - Bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/213](https://togithub.com/blitz-js/superjson/pull/213) - Bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/212](https://togithub.com/blitz-js/superjson/pull/212) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/248](https://togithub.com/blitz-js/superjson/pull/248) - fix: TypeError: SuperJSON is not a constructor by [@​juliusmarminge](https://togithub.com/juliusmarminge) in [https://github.com/blitz-js/superjson/pull/250](https://togithub.com/blitz-js/superjson/pull/250) #### New Contributors - [@​juliusmarminge](https://togithub.com/juliusmarminge) made their first contribution in [https://github.com/blitz-js/superjson/pull/250](https://togithub.com/blitz-js/superjson/pull/250) **Full Changelog**: flightcontrolhq/superjson@v1.13.0...v1.13.1 ### [`v1.13.0`](https://togithub.com/blitz-js/superjson/releases/tag/v1.13.0) [Compare Source](https://togithub.com/blitz-js/superjson/compare/v1.12.4...v1.13.0) #### What's Changed - fix: referential equalities should ignore child nodes by [@​KATT](https://togithub.com/KATT) in [https://github.com/blitz-js/superjson/pull/244](https://togithub.com/blitz-js/superjson/pull/244) - feat: add `dedupe` flag by [@​KATT](https://togithub.com/KATT) in [https://github.com/blitz-js/superjson/pull/247](https://togithub.com/blitz-js/superjson/pull/247) **Full Changelog**: flightcontrolhq/superjson@v1.12.4...v1.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Chia1104/chia1104.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Chia1104
referenced
this pull request
in ChiaStack/chiastack.dev
Jul 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [superjson](https://togithub.com/blitz-js/superjson) | [`1.12.4` -> `1.13.1`](https://renovatebot.com/diffs/npm/superjson/1.12.4/1.13.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>blitz-js/superjson (superjson)</summary> ### [`v1.13.1`](https://togithub.com/blitz-js/superjson/releases/tag/v1.13.1) [Compare Source](https://togithub.com/blitz-js/superjson/compare/v1.13.0...v1.13.1) #### What's Changed - Bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/218](https://togithub.com/blitz-js/superjson/pull/218) - Bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/213](https://togithub.com/blitz-js/superjson/pull/213) - Bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/212](https://togithub.com/blitz-js/superjson/pull/212) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/blitz-js/superjson/pull/248](https://togithub.com/blitz-js/superjson/pull/248) - fix: TypeError: SuperJSON is not a constructor by [@​juliusmarminge](https://togithub.com/juliusmarminge) in [https://github.com/blitz-js/superjson/pull/250](https://togithub.com/blitz-js/superjson/pull/250) #### New Contributors - [@​juliusmarminge](https://togithub.com/juliusmarminge) made their first contribution in [https://github.com/blitz-js/superjson/pull/250](https://togithub.com/blitz-js/superjson/pull/250) **Full Changelog**: flightcontrolhq/superjson@v1.13.0...v1.13.1 ### [`v1.13.0`](https://togithub.com/blitz-js/superjson/releases/tag/v1.13.0) [Compare Source](https://togithub.com/blitz-js/superjson/compare/v1.12.4...v1.13.0) #### What's Changed - fix: referential equalities should ignore child nodes by [@​KATT](https://togithub.com/KATT) in [https://github.com/blitz-js/superjson/pull/244](https://togithub.com/blitz-js/superjson/pull/244) - feat: add `dedupe` flag by [@​KATT](https://togithub.com/KATT) in [https://github.com/blitz-js/superjson/pull/247](https://togithub.com/blitz-js/superjson/pull/247) **Full Changelog**: flightcontrolhq/superjson@v1.12.4...v1.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Chia1104/chia-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fixes" #247 (comment)
now works. default import still broken though