-
Notifications
You must be signed in to change notification settings - Fork 607
Add slider docs example tests. #5704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
48a7396
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e600baf6.flet-docs.pages.dev |
| Branch Preview URL: | https://owen-control-docs.flet-docs.pages.dev |
| /* Proposals */ | ||
|
|
||
| .md-nav__item--section > .md-nav > .md-nav__list { | ||
| margin-left: 0.4rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the issue with default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value was no indentation. I thought this helped navigate. Perhaps it should be in another PR? As I'm reviewing documentation just checking what might improve readability and putting it in /* Proposals */ section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you paste screenshots before/after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let's leave it as is for now, without indentation.


Description
slider example for docs
Summary by Sourcery
Update slider documentation and examples, adjust CSS navigation styling, and add integration tests for slider controls.
Enhancements:
Tests: