Skip to content

Conversation

@OwenMcDonnell
Copy link
Contributor

@OwenMcDonnell OwenMcDonnell commented Oct 14, 2025

Description

slider example for docs

Summary by Sourcery

Update slider documentation and examples, adjust CSS navigation styling, and add integration tests for slider controls.

Enhancements:

  • Revise slider docs to use PNG example images, include image in class summary, update live example link, and remove random values section
  • Add left margin to nav list sections in mkdocstrings CSS
  • Wrap slider example scripts with main guard and add consistent keys for interactive examples

Tests:

  • Introduce integration tests with screenshot assertions for slider examples and default/disabled slider states

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@OwenMcDonnell OwenMcDonnell changed the title add nav list left margin to docs css [skip ci] Add slider docs example tests. Oct 14, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2025

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48a7396
Status: ✅  Deploy successful!
Preview URL: https://e600baf6.flet-docs.pages.dev
Branch Preview URL: https://owen-control-docs.flet-docs.pages.dev

View logs

/* Proposals */

.md-nav__item--section > .md-nav > .md-nav__list {
margin-left: 0.4rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the issue with default value?

Copy link
Contributor Author

@OwenMcDonnell OwenMcDonnell Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value was no indentation. I thought this helped navigate. Perhaps it should be in another PR? As I'm reviewing documentation just checking what might improve readability and putting it in /* Proposals */ section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you paste screenshots before/after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2025-10-14 at 3 26 31 PM
After
Screenshot 2025-10-14 at 3 22 43 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's leave it as is for now, without indentation.

@FeodorFitsner FeodorFitsner merged commit 66c8088 into main Oct 14, 2025
34 checks passed
@FeodorFitsner FeodorFitsner deleted the owen/control-docs branch October 14, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants