Skip to content

Conversation

@InesaFitsner
Copy link
Contributor

@InesaFitsner InesaFitsner commented Oct 9, 2025

Description

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Fix and enhance control image tests and migrate core control references

Enhancements:

  • Introduce similarity_threshold parameter to assert_control_screenshot and propagate it to assert_screenshot
  • Update Image control example to use src_base64 and remove fit argument

Documentation:

  • Change example_images paths in Column, GridView, Icon, Image, and Text docs from material to core golden directories

Tests:

  • Add a new core Image integration test with pump parameters
  • Update material test_card screenshot assertions to include similarity_threshold
  • Remove outdated material test_image example

Integration test files and golden images for column, grid view, icon, image, and text controls were moved from the 'material' to the 'core' directory. Documentation and example image paths were updated accordingly. The image control example now uses a base64-encoded image instead of a remote URL, and the corresponding test was updated to match.
Introduces a similarity_threshold parameter to screenshot assertion methods in tests and FletTestApp, allowing configurable image comparison sensitivity for integration tests.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner FeodorFitsner merged commit f6ceea6 into main Oct 9, 2025
41 checks passed
@FeodorFitsner FeodorFitsner deleted the inesa/control-docs-images-P2 branch October 9, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants