Skip to content

Conversation

@InesaFitsner
Copy link
Contributor

@InesaFitsner InesaFitsner commented Oct 3, 2025

Description

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Update checkbox documentation with structured frontmatter and macros, refine screenshot rendering, enhance examples for import safety, and add integration tests for checkbox controls.

Enhancements:

  • Enable intrinsic_width on wrapped columns in screenshot utility to ensure proper sizing
  • Guard example scripts with main to prevent auto-execution on import

Documentation:

  • Add frontmatter (class_name, examples, images) and macros to checkbox docs and standardize image paths and formatting

Tests:

  • Introduce integration tests for checkbox examples and documentation screenshots using FletTestApp

Introduced integration tests and golden images for Checkbox control, updated documentation to include new example images and improved formatting. Also refactored example scripts to use __main__ guard and enhanced screenshot handling in FletTestApp for intrinsic width support.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d652126
Status: ✅  Deploy successful!
Preview URL: https://cad253df.flet-docs.pages.dev
Branch Preview URL: https://inesa-controls-docs.flet-docs.pages.dev

View logs

@FeodorFitsner FeodorFitsner merged commit 9a03928 into main Oct 3, 2025
27 of 42 checks passed
@FeodorFitsner FeodorFitsner deleted the inesa/controls-docs branch October 3, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants