Skip to content

ci: Include source-distribution when publishing Flet packages #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FeodorFitsner merged 19 commits into from
Oct 5, 2025
Merged

ci: Include source-distribution when publishing Flet packages #5669

FeodorFitsner merged 19 commits into from
Oct 5, 2025

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Sep 30, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Streamline CI workflows for building, packaging, and publishing Python packages by generating source distributions, refining triggers, artifact handling, and publish steps; and enhance the Switch control to propagate its value on change events.

New Features:

  • Build and publish source-distribution archives (.tar.gz) alongside wheels for all Python packages.
  • Pass the updated value when triggering the "change" event in Switch control.

Enhancements:

  • Restrict CI workflow triggers to specific paths (including .fvmrc) and unify path handling and version patching.
  • Simplify uv build commands, rename build steps to reflect package focus, and replace manual version edits with a unified patch step.
  • Expand artifact uploads and downloads to include .tar.gz files and merge multiple directories.
  • Simplify publishing by looping through packages to publish all artifacts and removing redundant steps.

@ndonkoHenri ndonkoHenri requested a review from Copilot September 30, 2025 21:16
@ndonkoHenri ndonkoHenri linked an issue Sep 30, 2025 that may be closed by this pull request
bug: V1: Switch on_change data is None #5664
Closed
1 task
Copilot AI reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the CI pipeline to include source distributions (sdist) when publishing Flet packages to PyPI, alongside the existing wheel distributions. The changes ensure comprehensive package distribution by building both wheels and source distributions.

  • Updates build commands to generate both wheels and source distributions using uv build instead of uv build --wheel
  • Modifies artifact paths to include *.tar.gz files (source distributions) in addition to wheels
  • Refines CI workflow triggers to use explicit paths instead of paths-ignore for better control
  • Includes a minor fix to pass the value parameter to the switch control's change event

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci.yml Primary CI workflow changes to build and publish source distributions alongside wheels
.github/workflows/macos-integration-tests.yml Updates workflow triggers to include additional paths like .fvmrc
packages/flet/lib/src/controls/switch.dart Fixes switch control to pass value parameter to change event

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2025 •
edited
Loading

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e356623
Status: ✅  Deploy successful!
Preview URL: https://f9e86f58.flet-docs.pages.dev
Branch Preview URL: https://v1-fixes.flet-docs.pages.dev

View logs

@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Oct 1, 2025

Every platform-specific artifact here https://github.com/flet-dev/flet/actions/runs/18144469499 contains a source package for flet_desktop with platform-specific zip inside:

image

Source package should not contain any binaries in it, be small (only sources) and built only once perhaps in Build flet and flet-cli Python packages job.

@ndonkoHenri
Copy link
Contributor Author

ndonkoHenri commented Oct 1, 2025

Source package should not contain any binaries in it, be small (only sources) and built only once

Solved: https://github.com/flet-dev/flet/actions/runs/18176278704/job/51744130968?pr=5669#step:4:24

@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Oct 2, 2025

Source package should not contain any binaries in it, be small (only sources) and built only once

Solved: https://github.com/flet-dev/flet/actions/runs/18176278704/job/51744130968?pr=5669#step:4:24

flet_desktop-{ver}.tar.gz is fine.

We need flet_desktop_light-{ver}.tar.gz too, right?

And flet_web-{ver}.tar.gz should be small as well.

@FeodorFitsner FeodorFitsner merged commit 655f36b into main Oct 5, 2025
23 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-fixes branch October 5, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] requested changes

@FeodorFitsner FeodorFitsner FeodorFitsner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: V1: Switch on_change data is None

3 participants

@ndonkoHenri @FeodorFitsner