Skip to content

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Sep 27, 2025

Summary by Sourcery

Migrate the CI system from AppVeyor to GitHub Actions by removing legacy configs, centralizing scripts under .github/scripts, and introducing a multi-platform workflow to run tests, build Flutter clients, package Python wheels, and publish releases.

New Features:

  • Add highlight dependency to flet pubspec for syntax highlighting support

Enhancements:

  • Relocate and clean up PowerShell and shell helper scripts under .github/scripts and update common functions
  • Update icon generation template references to use the new .github/scripts path
  • Refine the macOS integration tests workflow to ignore the migration branch

Build:

  • Introduce a unified GitHub Actions workflow (ci.yml) covering Python tests, Flutter builds for Windows, macOS, Linux and Web, wheel packaging, artifact uploads, and GitHub release automation

CI:

  • Remove AppVeyor configuration and the old ci directory
  • Add GitHub Actions workflows: macOS integration tests and the main CI pipeline with multi-platform build matrices

Tests:

  • Modify macOS integration tests workflow to skip the v1-migrate-to-github-action branch

Chores:

  • Clean up trailing whitespace and formatting in common.ps1
  • Add scripts for versioning, wheel repackaging, TOML and pubspec patching, and cleanup under .github/scripts

@ndonkoHenri ndonkoHenri requested a review from Copilot September 27, 2025 02:01
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CI system from AppVeyor to GitHub Actions, centralizing build scripts and introducing a comprehensive multi-platform workflow that covers Python testing, Flutter builds, wheel packaging, and release automation.

  • Complete migration from AppVeyor to GitHub Actions for CI/CD
  • Reorganization of build scripts from ci/ directory to .github/scripts/
  • Introduction of a unified workflow supporting Windows, macOS, Linux (ARM64/AMD64), and web builds

Reviewed Changes

Copilot reviewed 24 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.appveyor.yml Removes the legacy AppVeyor configuration file
ci/* Removes old CI scripts that have been migrated to .github/scripts/
.github/workflows/ci.yml Adds comprehensive GitHub Actions workflow for multi-platform builds and releases
.github/workflows/macos-integration-tests.yml Updates to exclude the migration branch from testing
.github/scripts/* Adds migrated and improved build scripts with better documentation
packages/flet/pubspec.yaml Adds highlight dependency for syntax highlighting support
Icon template files Updates script path references to new location

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2025

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52aa430
Status: ✅  Deploy successful!
Preview URL: https://4cda4978.flet-docs.pages.dev
Branch Preview URL: https://v1-migrate-to-github-action.flet-docs.pages.dev

View logs

@FeodorFitsner FeodorFitsner merged commit fe6d9dc into main Sep 29, 2025
21 of 35 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-migrate-to-github-action branch September 29, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants