v1: Fix window.minimize issue on Linux
#5595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizes internal window state variables with the latest values from getWindowState() before notifying the backend on window events. Ensures state properties are up-to-date when handling window events other than resize, resized, and move.
Deploying flet-docs with
|
| Latest commit: |
977f39d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d40658e.flet-docs.pages.dev |
| Branch Preview URL: | https://v1-fix-minimize-bug.flet-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a window minimize issue on Linux by synchronizing window state properties when window events occur. The PR removes an unused import and ensures proper state tracking for all window attributes.
- Synchronizes all window state properties (size, position, minimized/maximized flags, etc.) in the onWindowEvent method
- Removes unused import of flutter/foundation.dart
- Fixes the minimize issue on Linux by properly updating the minimized state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5572
Summary by Sourcery
Sync window state properties on window events to fix the minimize issue on Linux and ensure accurate state tracking.
Bug Fixes:
Enhancements: