-
Notifications
You must be signed in to change notification settings - Fork 607
text_change event for Dropdown and more integration tests
#5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `bar_size_constraints` to the SearchBar control and theme, allowing optional size constraints. Also updates and expands documentation for SearchBar properties and SearchBarTheme overrides for better clarity and developer guidance.
Introduces a new integration test for the SearchBar control, including golden images for its basic and opened states on macOS. The test verifies SearchBar rendering and interaction, ensuring correct UI behavior.
Introduces a new test for SearchBar theming in macOS, including screenshots for normal, hovered, and opened states. Verifies custom theme properties and interaction behaviors.
Introduces viewPadding, viewBarPadding, and shrinkWrap properties to SearchBar and SearchViewTheme for enhanced customization. Updates integration tests and documentation to reflect new options for controlling search view layout and appearance.
Eliminated the handle_tile_click function and its usage in SearchBar integration tests, as the click handler is no longer needed. Also added detailed docstrings to NavigationDrawerTheme fields for improved documentation.
Renamed screenshot files and updated test names for clarity. Added a new test for navigation drawer theme and its corresponding golden image. Refactored fixture usage and screenshot assertions to improve test structure and maintainability.
Introduces the label_padding property to NavigationBar and NavigationBarTheme for customizing label padding. Improves and clarifies documentation for NavigationBar, TabBar, SearchBarTheme, SearchViewTheme, and NavigationDrawerTheme properties, including corrections to property references and expanded descriptions.
Renamed navigation_bar.png to basic.png and added new golden images for themed NavigationBar states. Updated test_navigation_bar.py to include separate tests for basic and themed NavigationBar, verifying appearance under different theme settings and user interactions.
Updated SegmentedButton to support both IconData and Control for selected_icon. Improved integration tests for segmented button, added golden images for macOS, and documented SegmentedButtonTheme options. Also clarified NavigationBarTheme test comments.
Introduces a text change event handler for the Dropdown control in both Dart and Python implementations. The Dart Dropdown now uses a TextEditingController to track input changes, updating properties and triggering the new 'text_change' event. The Python Dropdown class adds an 'on_text_change' callback for handling text input changes.
Renamed and updated the icon test to use function-scoped async fixtures and improved test isolation. Enhanced documentation for IconTheme properties with detailed docstrings. Removed and replaced golden image files for icon and segmented button tests.
Introduces a new integration test for icon theme settings, including screenshot validation. Updates IconTheme's 'shadows' attribute type from list[BoxShadow] to BoxShadowValue for consistency with usage.
Refined docstrings for NavigationDrawerTheme, NavigationBarTheme, SegmentedButtonTheme, and IconTheme to clarify scope as app-wide. Expanded DataTableTheme docstring and added detailed documentation for each property, specifying their purpose and corresponding DataTable attributes.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
fd5c85e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8fbd6a0.flet-docs.pages.dev |
| Branch Preview URL: | https://inesa-v1-tests-p4.flet-docs.pages.dev |
FeodorFitsner
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5561
Test Code
# Test code for the review of this PRType of change
Checklist
Screenshots
Additional details
Summary by Sourcery
Add Dropdown text_change event and improve control customization by enriching theme properties and adding new control parameters; expand integration test coverage across core controls using pytest_asyncio fixtures.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: