v1: fix TabBarView
#5586
Merged
v1: fix TabBarView
#5586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the TabBarView control by restructuring how it handles height constraints and nested tab scenarios. The fix addresses issue #5581 by improving the error handling and layout logic for unbounded height situations.
- Restructured the
TabBarViewwidget logic to properly handle expand properties and avoid layout builder conflicts - Updated integration tests to include a new nesting test case and simplified the basic test structure
- Modified the nested tabs example to reorder content for better demonstration
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/python/packages/flet/integration_tests/controls/test_tabs.py |
Added comprehensive nesting test case and simplified basic test structure |
sdk/python/examples/controls/tabs/nested.py |
Reordered tab content to demonstrate proper nesting behavior |
packages/flet/lib/src/controls/tabs.dart |
Fixed TabBarView layout logic to handle expand properties and unbounded height scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Deploying flet-docs with
|
| Latest commit: |
974738d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6eaa4735.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-tabs.flet-docs.pages.dev |
FeodorFitsner
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5581
Summary by Sourcery
Improve TabBarViewControl error handling, height logic, and expand behavior; update tests to cover basic and nested scenarios; fix example ordering
Bug Fixes:
Enhancements:
Documentation:
Tests: