v1: Remove surface_tint_color, update Colors and add some more tests
#5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed and replaced golden screenshot files for macOS checkbox tests to use a consistent naming scheme. Refactored test_checkbox.py to simplify screenshot assertions and update test logic to use new screenshot names and methods.
Introduces labelTextStyle property for PopupMenuItem and updates PopupMenuButtonControl to apply labelTextStyle. Removes deprecated textStyle from PopupMenuTheme and updates documentation to reflect the new styling approach for menu item labels.
…into inesa/v1-tests-p3
remove default value from shape for PopupMenuTheme.shape to have effect
Renamed and updated golden image files for the popup menu button tests to use 'basic' and 'basic_opened' naming. Updated the test to match new asset names and switched to function-scoped async fixtures for improved isolation.
Introduces a new integration test for PopupMenuButton with custom theme settings on macOS, including golden images for normal and opened states. This enhances coverage for themed appearance and behavior.
Eliminates the surface_tint_color property from various Material controls, styles, and theme classes in the Flet SDK. It is not recommended to use in Flutter: "This is not recommended for use. Material 3 spec introduced a set of tone-based surfaces and surface containers in its ColorScheme, which provide more flexibility. The intention is to eventually remove surface tint color from the framework."
Eliminated usage and parsing of the surfaceTintColor property from multiple controls and theme data files. This simplifies the codebase and removes support for a property that is no longer needed or relevant.
Replaces usage of surface_variant with surface_container_highest in both Dart and Python implementations of ColorScheme. Removes background, on_background, and surface_variant properties from Python ColorScheme to align with updated theme structure.
Extended color handling in both Dart and Python to support new Material 3 color scheme properties such as primaryFixed, secondaryFixed, tertiaryFixed, and related variants. This improves theme compatibility and enables usage of the latest Material color system features.
surface_tint_color, update Colors and add some more tests
FeodorFitsner
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Code
# Test code for the review of this PRType of change
Checklist
Screenshots
Additional details
Summary by Sourcery
Remove deprecated surfaceTintColor support, introduce new Material 3 color roles, refine theme parsing, and update integration tests for screenshot assertions
New Features:
Enhancements:
Tests: