v1: fixElevatedButton
#5540
Merged
v1: fixElevatedButton
#5540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logical bug in the ElevatedButton control and adds a new alias for task listing.
- Fixed a critical logical error in the
ElevatedButtonvalidation whereis Nonewas incorrectly used instead ofis not None - Added
mkdocs-external-imagesdependency for documentation generation - Added convenience "help" alias for the task list command
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/python/packages/flet/src/flet/controls/material/elevated_button.py | Fixed logical bug by changing is None to is not None in style validation |
| sdk/python/pyproject.toml | Added mkdocs-external-images dependency from git repository |
| sdk/python/Taskfile.yml | Added "help" alias for the task list command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Deploying flet-docs with
|
| Latest commit: |
1ced37e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c65c2a3d.flet-docs.pages.dev |
| Branch Preview URL: | https://v1-fix-button.flet-docs.pages.dev |
Contributor
|
Can you add an integration test specifically testing the scenario in #5538. |
FeodorFitsner
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5538
Summary by Sourcery
Update documentation tooling, fix ElevatedButton validation logic, and enhance Taskfile usability
Bug Fixes:
Build:
Chores: