Merged
Conversation
iansltx
approved these changes
Sep 2, 2025
allenhouchins
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32504
Homebrew has removed the ability to install via a local .rb file. For context see the PR here: Homebrew/brew#20414 . Also the long list of PRs and commits referencing can give you some idea of how others are solving this
We have a few different options we can take.
We can use the usual homebrew method of doing an install wine-stable@[version] but this does not support us installing a version referenced by a commit SHA, rather we just get to choose a specific semver.
We can set EVs normally intended for use only by homebrew developers. The actual Homebrew developers have strongly cautioned against this as it has more side effects than simply allowing local package installs.
Finally, we can take the method suggested by the Homebrew developers, which I have done here, of creating a local tap containing our specified Wine version's cask file and installing from it. This works well in local testing and I think has the fewest downsides while maintaining the reference to a specific immutable version.
Checklist for submitter
Testing
Fixed CI run here: https://github.com/fleetdm/fleet/actions/runs/17407514780/job/49415787748