Skip to content

build(go): upgrade Go version to 1.22.10#34

Merged
flc1125 merged 3 commits intov2.xfrom
upgrade-go-version
Jan 8, 2025
Merged

build(go): upgrade Go version to 1.22.10#34
flc1125 merged 3 commits intov2.xfrom
upgrade-go-version

Conversation

@flc1125
Copy link
Copy Markdown
Owner

@flc1125 flc1125 commented Jan 8, 2025

Summary by CodeRabbit

  • Workflow Updates

    • Updated GitHub Actions workflows to target v2.x branch
    • Modified Go testing workflow to support Go versions 1.22.x and 1.23.x
  • Go Configuration

    • Updated Go version requirement to 1.22.10
  • Code Optimization

    • Simplified event processing method implementations by removing variable shadowing

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 8, 2025

Walkthrough

The pull request introduces updates to GitHub Actions workflows and the Go module configuration. The primary changes involve updating branch specifications from master to v2.x across multiple workflow files, modifying the Go version matrix in the test workflow, and updating the Go version requirement in the go.mod file to version 1.22.10. These modifications align the project's continuous integration configuration with a new version branch and update the supported Go versions.

Changes

File Change Summary
.github/workflows/analysis.yml, .github/workflows/lint.yml Branch specification updated from master to v2.x for push and pull_request events
.github/workflows/test.yml - Branch specification updated from master to v2.x
- Go version matrix updated to 1.22.x, 1.23.x (removed 1.21.x)
go.mod Go version requirement updated from 1.21 to 1.22.10
dispatcher.go Removed variable shadowing in process*Event methods for cleaner closure references

Poem

🐰 Workflows hop to a new branch's beat,
Version updates, oh so neat!
From master to v2.x we leap,
Go versions dance, no time to weep.
CI pipeline, shiny and bright 🚀
Hopping along, we code with delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e28e09c and 5e68310.

📒 Files selected for processing (2)
  • .github/workflows/test.yml (2 hunks)
  • dispatcher.go (0 hunks)
💤 Files with no reviewable changes (1)
  • dispatcher.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added the go Pull requests that update Go code label Jan 8, 2025
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86c9520 and e28e09c.

📒 Files selected for processing (4)
  • .github/workflows/analysis.yml (1 hunks)
  • .github/workflows/lint.yml (1 hunks)
  • .github/workflows/test.yml (2 hunks)
  • go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • go.mod
🔇 Additional comments (3)
.github/workflows/lint.yml (1)

6-6: LGTM! Branch update is consistent.

The branch update from master to v2.x aligns with the version upgrade strategy. Using stable for the Go version in linting is appropriate and doesn't require changes.

Also applies to: 9-9

.github/workflows/analysis.yml (1)

6-6: LGTM! Branch update is consistent.

The branch update from master to v2.x aligns with the version upgrade strategy. The static analysis tool installation uses @latest which is appropriate.

Also applies to: 9-9

.github/workflows/test.yml (1)

5-5: LGTM! Branch update is consistent.

The branch update from master to v2.x aligns with the version upgrade strategy.

Also applies to: 8-8

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@flc1125 flc1125 merged commit d3ad964 into v2.x Jan 8, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (86c9520) to head (5e68310).
Report is 2 commits behind head on v2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             v2.x      #34      +/-   ##
==========================================
- Coverage   94.42%   94.40%   -0.02%     
==========================================
  Files           1        1              
  Lines         323      304      -19     
==========================================
- Hits          305      287      -18     
+ Misses         16       15       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125 flc1125 deleted the upgrade-go-version branch January 8, 2025 14:51
@coderabbitai coderabbitai bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant