-
Notifications
You must be signed in to change notification settings - Fork 2
Support dispatcher routing for ProjectWebhookEvent #381
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Background
The upstream GitLab Go client already supports parsing ProjectWebhookEvent in ParseWebhook(...):
- Docs: https://pkg.go.dev/gitlab.com/gitlab-org/api/client-go/v2
- Source: https://gitlab.com/gitlab-org/api/client-go/-/blob/v2.4.0/event_parsing.go
However, the dispatcher in this repository does not currently support routing *gitlab.ProjectWebhookEvent.
Problem
Although ProjectWebhookEvent can already be parsed by the upstream client, it cannot be dispatched further in this project, which effectively makes it unsupported here.
Expected
Add dispatcher support for ProjectWebhookEvent, including:
- listener definition
- listener registration
- a
Dispatch(...)branch - the corresponding handler function
- basic tests
Acceptance Criteria
Dispatcher.Dispatch(...)can handle*gitlab.ProjectWebhookEvent- dispatching
*gitlab.ProjectWebhookEventno longer returnsErrUnsupportedEvent - registered listeners are invoked correctly
Reactions are currently unavailable
Metadata
Metadata
Labels
enhancementNew feature or requestNew feature or request