inputcapture: Fix invalid free of call-related data#217
Merged
GeorgesStavracas merged 1 commit intoflatpak:mainfrom Mar 26, 2026
Merged
inputcapture: Fix invalid free of call-related data#217GeorgesStavracas merged 1 commit intoflatpak:mainfrom
GeorgesStavracas merged 1 commit intoflatpak:mainfrom
Conversation
Our Call has a ref to the task but the task has a ref to our call. When we g_clear_object (&call->task) and it's the last ref to the task, we end up freeing the Call from underneath us. Make sure the task is the last thing freed. Related: 0647ff5 ("inputcapture: Reference-count Call instances")
GeorgesStavracas
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Call has a ref to the task but the task has a ref to our call. When we g_clear_object (&call->task) and it's the last ref to the task, we end up freeing the Call from underneath us.
Make sure the task is the last thing freed.
Related: 0647ff5 ("inputcapture: Reference-count Call instances")