notification: Implement version2 of the interface#147
Merged
GeorgesStavracas merged 3 commits intoflatpak:mainfrom Nov 27, 2024
Merged
notification: Implement version2 of the interface#147GeorgesStavracas merged 3 commits intoflatpak:mainfrom
GeorgesStavracas merged 3 commits intoflatpak:mainfrom
Conversation
9 tasks
bbe8883 to
57d6202
Compare
swick
reviewed
Apr 22, 2024
050fe36 to
03dd58c
Compare
swick
reviewed
Apr 23, 2024
595a948 to
ff872a1
Compare
Contributor
|
Might want to put the autofd stuff into a new commit but otherwise this LGTM. |
ff872a1 to
7c39eb4
Compare
f919856 to
7a202b4
Compare
TingPing
reviewed
Jul 5, 2024
e0fa651 to
5a84acf
Compare
Contributor
|
xdg-desktop-portal now depends on this PR |
jadahl
reviewed
Oct 18, 2024
GeorgesStavracas
requested changes
Oct 21, 2024
5a84acf to
14c0ec6
Compare
Contributor
Author
|
I reworked this MR to keep backwards compatibility. I didn't fully test it yet, therefore i'm marking it as a draft. |
14c0ec6 to
938e92f
Compare
e3dd306 to
4c6b996
Compare
Contributor
Author
|
Should be ready for review. I changed the MR to keep backwards compatibility and some tests to make sure it actually works. |
fe0465b to
ae9ac48
Compare
swick
reviewed
Oct 29, 2024
d3c9817 to
70365d8
Compare
70365d8 to
843cad4
Compare
GeorgesStavracas
requested changes
Nov 26, 2024
Calls to the notification interface version 1 fail if the vardict of `AddNotification` contains properties that aren't supported therefore check the version and filter the vardict. This will be even more relevant once features for version 2 are added in a future commit. The parse function is made async because it's needed in a future commit.
This introduces all new properties introduced in version 2 of the notification interface. It still keeps compatibility with older versions of the interface by adjusting and stripping properties that were not supported in version 1.
843cad4 to
d7634ce
Compare
GeorgesStavracas
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the new portal frontend in libportal flatpak/xdg-desktop-portal#1298