flatpak-builder: add support for D-Bus tests#83
Merged
GeorgesStavracas merged 1 commit intoflatpak:masterfrom Oct 1, 2022
Merged
flatpak-builder: add support for D-Bus tests#83GeorgesStavracas merged 1 commit intoflatpak:masterfrom
GeorgesStavracas merged 1 commit intoflatpak:masterfrom
Conversation
fd36b6a to
d8eada3
Compare
Contributor
Author
|
This is not terribly elegant, but I didn't want to refactor a bunch of the code flow and make it too difficult to review. I believe all the potential exceptions are caught, though. |
Member
|
it looks pretty good to me! before getting this one merged, I would like to tackle #60 as the repo was moved to the Flatpak repo and we would like to keep only the base image here and have the runtime ones produced by Flathub itself along with something like flathub-publish |
d8eada3 to
dbf67e9
Compare
If the `run-test` input is `true`, automatically start a session bus and add `DBUS_SESSION_BUS_ADDRESS` environment variable when modifying the manifest.
dbf67e9 to
d02ae11
Compare
bilelmoussaoui
approved these changes
Oct 1, 2022
Member
|
The codespell check seems not to be correct nor related to this PR, so we can merge it and figure out what to do with Codespell after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
run-testinput istrue, automatically start a session bus and addDBUS_SESSION_BUS_ADDRESSenvironment variable when modifying the manifest.fixes #25