Conversation
|
Oh no lol |
flatpak-builder/index.js
Outdated
| [ | ||
| '.flatpak-builder' | ||
| ], |
There was a problem hiding this comment.
| [ | |
| '.flatpak-builder' | |
| ], | |
| [...CACHE_PATH], // TODO: drop once https://github.com/actions/toolkit/pull/1378 is merged |
is better for me
also you will have to rebuild the index.js, see contributing guidelines
There was a problem hiding this comment.
@bilelmoussaoui
I made the modifications as required. However, when I compiled using ncc, the generated files differed significantly from the previous ones. I checked the previous pull requests, but didn't find this issue. Since I'm not very familiar with node.js and related things, I manually edited the dist/index.js.
I hope it works fine now.
There was a problem hiding this comment.
No, please just run ncc & push your changes. The file should never be modified manually
There was a problem hiding this comment.
Update flatpak-builder/dist/index.js compiled by nodes 18.17.0 / yarn 1.22.19 / ncc 0.36.1
There was a problem hiding this comment.
Sorry, I know what to do now. Please wait a moment
c916ac0 to
c886bfd
Compare
|
@bilelmoussaoui Now it's ready to merge, Thanks for the help~ |
|
Rebased to fix conflicts |
|
Would you mind rebasing again please? Thank you |
|
Rebased again |
|
Thank you !!! |
Due to an oversight in actions/toolkit, the
CACHE_PATHwas modified after runningcache.restoreCachefunction. As a result, an incorrect version was generated during cache upload, leading to cache missing.This PR independently passes the
CACHE_PATHto avoid issues caused by shallow copying.Fix issue：#142
Refer to : actions/toolkit#1378 (comment)