Build runtime bundle if manifest is a runtime or extension#148
Merged
bilelmoussaoui merged 1 commit intoflatpak:masterfrom Aug 29, 2023
detjensrobert:flatpak-type
Merged
Build runtime bundle if manifest is a runtime or extension#148bilelmoussaoui merged 1 commit intoflatpak:masterfrom detjensrobert:flatpak-type
bilelmoussaoui merged 1 commit intoflatpak:masterfrom
detjensrobert:flatpak-type
Conversation
Member
|
Would need a rebase |
Member
|
Sorry but another rebase is needed |
Since all runtimes and extensions have a `build-{runtime,extension}:` property
in the manifest, add the needed `--runtime` flag to `flatpak build-bundle` if
either of those are set.
Contributor
Author
|
Rebased and ready to go. |
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
flatpak-builderaction always assumes the flatpak being built is an application, regardless of whether it is actually a runtime or extension.Since all runtimes and extensions have a corresponding
build-runtime:/build-extension:property in the manifest, this PR adds the needed--runtimeflag toflatpak build-bundleif either of those are set.