builder-main: Commit mirrored media as screenshot ref to exported repo#649
Merged
bbhtt merged 2 commits intoflatpak:mainfrom Sep 3, 2025
bbhtt:bbhtt/commit-sc-ref
Merged
builder-main: Commit mirrored media as screenshot ref to exported repo#649bbhtt merged 2 commits intoflatpak:mainfrom bbhtt:bbhtt/commit-sc-ref
bbhtt merged 2 commits intoflatpak:mainfrom
bbhtt:bbhtt/commit-sc-ref
Conversation
Contributor
Author
|
This is in use in Flathub for the past 1+ month https://github.com/flathub-infra/flatpak-builder/commits/flathub/ |
Contributor
Author
|
rebase over #651 |
swick
reviewed
Sep 2, 2025
Contributor
|
LGTM with the code style fixed. |
Contributor
Author
|
rebased to drop the merged commits from the other MRs. |
swick
reviewed
Sep 2, 2025
This is needed to store the application icons and the mirrored screenshots (as done by appstream) to the ostree repo. This can be useful in many ways, the primary being flat-manager extracts [1] these screenshot refs and stores them in the server so that application store frontends can use their own mirrored screenshot and icon URLs. This has been for the longest time done at various downstream levels such as in buildbot [2], flatpak-github-actions [3] and vorarbeiter [4] (the successor to buildbot) but it's more user friendly to have flatpak-builder do this extra work. [1]: flatpak/flat-manager@eff4300 [2]: https://github.com/flathub-infra/buildbot/blob/9d8e2b5483b2e446389548446ebf9c3934380682/master/buildbot/flathub_master.py#L1081 [3]: https://github.com/flatpak/flatpak-github-actions/blob/6684584b07d86113b1acfc80b3e4667f16f617c3/flatpak-builder/index.js#L280-L286 [4]: https://github.com/flathub-infra/vorarbeiter/blob/7f2f04a562e73ba4f46044dae7c99f8e9e64a39d/justfile#L185-L189
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.