Show update-able apps/runtimes but dont download or install#985
Merged
alexlarsson merged 3 commits intoflatpak:masterfrom Sep 4, 2017
Merged
Show update-able apps/runtimes but dont download or install#985alexlarsson merged 3 commits intoflatpak:masterfrom
alexlarsson merged 3 commits intoflatpak:masterfrom
Conversation
|
Can one of the admins verify this patch?
|
alexlarsson
reviewed
Aug 31, 2017
app/flatpak-builtins-ls-remote.c
Outdated
| flatpak_table_printer_set_column_title (printer, 1, _("Commit")); | ||
| flatpak_table_printer_set_column_title (printer, 2, _("Installed size")); | ||
| flatpak_table_printer_set_column_title (printer, 3, _("Download size")); | ||
| flatpak_table_printer_set_column_title (printer, 1, _("Origin")); |
Member
There was a problem hiding this comment.
We shouldn't show the origin column if a remote was specified.
alexlarsson
reviewed
Aug 31, 2017
| g_autofree char *alt_arch_ref = g_strconcat (parts[0], "/", parts[1], "/", arches[0], "/", parts[3], NULL); | ||
| if (g_hash_table_lookup (refs, alt_arch_ref)) | ||
| continue; | ||
| if (g_hash_table_lookup (names, name) == NULL) |
Member
There was a problem hiding this comment.
This will cause problems if the same ref are in multiple remotes. For instance, the gnome runtimes are both in the gnome repo and the flathub repo.
…in column if a remote was specified
2 tasks
|
It seems like |
|
|
That also fails with the error message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #729