Conversation
1614cf6 to
a28c9ba
Compare
org.pgadmin.pgadmin4.metainfo.xml
Outdated
| </screenshot> | ||
| <screenshot type="default"> | ||
| <caption>Welcome screen, dark theme</caption> | ||
| <image type="source">https://raw.githubusercontent.com/flathub/org.pgadmin.pgadmin4/22dd2e4d54b6a14b31fe73c26d37139f1e31dc8f/img/welcome-dark.png</image> |
There was a problem hiding this comment.
Thes should be tagged with the correct (dark) env https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots
There was a problem hiding this comment.
I've added the environment attribute accordingly.
| <screenshot type="default"> | ||
| <caption>Welcome screen, standard theme</caption> | ||
| <image type="source">https://raw.githubusercontent.com/nazebzurati/org.pgadmin.pgadmin4/79a08b5edae6fa3c4137b6184cfe851adb199c88/img/welcome.png</image> | ||
| <caption>Welcome screen</caption> |
There was a problem hiding this comment.
It feels like the welcome screen isn't as good as the other screenshot. Either remove it, or default to the other screenshot.
There was a problem hiding this comment.
I think we should keep the pgAdmin 4 welcome page since it gives new users a quick overview of what pgAdmin is and highlights the basic features available. It's a helpful starting point, especially for those who aren't familiar with the tool yet. @razzeee Let me know if I should exclude it.
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
+ Add environment attribute to image tags
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. Help
|
|
🚧 Started test build. |
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
New screenshots, don't seem to be according to the guidelines. https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#screenshots E.g. no window shadows |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. |
+ Add screenshots window shadow
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. Help
|
|
🚧 Started test build. |
|
@razzeee I have updated the screenshots based on the guidelines. Let me know if there is anything I missed or that needs further improvement. |
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. Help
|
|
🚧 Started test build. |
|
I thin we will fail https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#default-settings the config is not a gnome default, but it's still an improvement to merge this |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. |
|
Will do. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. Help
|
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. |
|
@razzeee I've updated the screenshots using gnome default settings. Let me know if any more improvement is required. |
|
Awesome, thank you! |
No description provided.