This repository was archived by the owner on May 30, 2023. It is now read-only.
profiles: force to use ssl USE flag for wget#444
Merged
dongsupark merged 1 commit intoflatcar-masterfrom Jun 25, 2020
Merged
Conversation
When catalyst tries to fetch a file via https, wget sometimes fails to do so, with the following messages: ``` https://www.kernel.org/pub/software/scm/git/git-2.24.1.tar.xz: HTTPS support not compiled in. !!! Couldn't download 'git-2.24.1.tar.xz'. Aborting. ``` That probably happens because wget in some catalyst stages are compiled without `ssl` USE flag. If a catalyst stage is lucky enough to rebuild wget with `ssl` before actually fetching a file, it would work well. Though if not, it would fail. It is not deterministic, and hard to reproduce. So backport the fix from upstream Gentoo, gentoo/gentoo@d141380b915d , for both amd64 and arm64. By setting `ssl` for wget in `package.use.force`, it is now not possible to disable `ssl` for wget. More details: https://bugs.gentoo.org/611072
Contributor
|
Will it be enabled in stage1 and does it mean that we can remove https://github.com/flatcar-linux/scripts/blob/flatcar-master/bootstrap_sdk#L57? |
Contributor
Author
|
Yeah, I think so, we can probably remove the hack in Anyway I would prefer to change those gradually. |
sayanchowdhury
approved these changes
Jun 25, 2020
Contributor
Author
|
cherry-picked to beta, alpha, and edge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When catalyst tries to fetch a file via https, wget sometimes fails to do so, with the following messages:
That probably happens because wget in some catalyst stages are compiled without
sslUSE flag.If a catalyst stage is lucky enough to rebuild wget with
sslbefore actually fetching a file, it would work well.Though if not, it would fail.
It is not deterministic, and hard to reproduce.
So backport the fix from upstream Gentoo, for both amd64 and arm64.
By setting
sslfor wget inpackage.use.force, it is now not possible to disablesslfor wget.More details: https://bugs.gentoo.org/611072