This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3#2122
Merged
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3#2122
Conversation
The m3.small.x86 instance type had no serial console output because ttyS0 was used because the GRUB CPU check didn't trigger. It seems that most instances had i386 reported but this new one not (maybe EFI is used here?). Extend the GRUB check to cover both i386 and x86_64 when setting up the serial console. For arm64 this still shouldn't be needed and the defaults worked so far.
4f1eac7 to
33b31f9
Compare
krnowak
approved these changes
Sep 1, 2022
Contributor
Author
|
It seems the Equinix Metal provisioning logic already appends |
pothos
added a commit
that referenced
this pull request
Sep 1, 2022
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3
pothos
added a commit
that referenced
this pull request
Sep 1, 2022
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3
pothos
added a commit
that referenced
this pull request
Sep 1, 2022
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3
pothos
added a commit
that referenced
this pull request
Sep 1, 2022
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3
pothos
added a commit
that referenced
this pull request
Sep 1, 2022
coreos-base/oem-packet: Use i386 serial settings for x86_64 to fix m3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The m3.small.x86 instance type had no serial console output because
ttyS0 was used because the GRUB CPU check didn't trigger. It seems that
most instances had i386 reported but this new one not (maybe EFI is
used here?).
Extend the GRUB check to cover both i386 and x86_64 when setting up the
serial console. For arm64 this still shouldn't be needed and the
defaults worked so far.
How to use
Test again on other instance types that the serial console works as expected.
Backport
Testing done
On m3.small, c3.medium, s3.xlarge
changelog/directory (user-facing change, bug fix, security fix, update)