This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/coreos: remove rng-tool dependency#1700
Merged
Conversation
rng-tools does not appear to be necessary for booting in virtual machine environments in 2022. Back in the day the boot process would block if there was not enough entropy to seed the system random pool, but over the years the linux kernel made sure that the pool is force seeded if userspace does not do so one it's own. Remove rng-tool as it is not needed and it would require work to make sure it works (detection of tpm/hwrng/intel cpu instructions).
JAORMX
approved these changes
Mar 8, 2022
pothos
reviewed
Mar 9, 2022
Contributor
pothos
left a comment
There was a problem hiding this comment.
This is about rngd.service, or? A changelog entry would be good, like - Removed rngd.service because it is not essential anymore for the kernel to boot fast in VM environments
The user visible effect of rng-tool removal is that rngd is no longer started in the initramfs.
a6894b6 to
0b8fc6d
Compare
Contributor
Author
|
Added the changelog entry |
pothos
approved these changes
Mar 9, 2022
JAORMX
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coreos-base/coreos: remove rng-tool dependency
rng-tools does not appear to be necessary for booting in virtual machine
environments in 2022. Back in the day the boot process would block if
there was not enough entropy to seed the system random pool, but over
the years the linux kernel made sure that the pool is force seeded if
userspace does not do so one it's own. Remove rng-tool as it is not
needed and it would require work to make sure it works (detection of
tpm/hwrng/intel cpu instructions).
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)