This repository was archived by the owner on May 30, 2023. It is now read-only.
Conversation
krnowak
approved these changes
Feb 27, 2023
Contributor
krnowak
left a comment
There was a problem hiding this comment.
Looks good. Had a question about one patch, though.
| @@ -1,13 +1,13 @@ | |||
| From 4b86d64fe196d9cb5ca43548234d521907a1cb4d Mon Sep 17 00:00:00 2001 | |||
Contributor
There was a problem hiding this comment.
Do we still need to carry this patch? I'm not sure what is the point of this rename, especially that we are not using our ignition fork any more.
Contributor
There was a problem hiding this comment.
The old fork is still used for the translation
pothos
reviewed
Feb 27, 2023
9b3dca8 to
7d62755
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
7d62755 to
3eaf012
Compare
pothos
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this release, 3.4-exp configuration is stabilized to 3.4 and 3.5-exp is available. A bit of turbulence while upgrading the patches (especially for the qemu fw_cfg one)
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.