kv-store: support quoted values#28
Merged
tormath1 merged 2 commits intoflatcar-masterfrom Oct 17, 2023
Merged
Conversation
krnowak
reviewed
Oct 12, 2023
Useful to test when the value contains whitespaces surrounded with quotes/double-quotes. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
4b101f6 to
333794f
Compare
jepio
reviewed
Oct 12, 2023
Comment on lines
+32
to
+33
| ((val.at(0) == '\"' && val.at(val.length() - 1) == '\"') || | ||
| (val.at(0) == '\'' && val.at(val.length() - 1) == '\''))) { |
Member
There was a problem hiding this comment.
Try these instead:
val.front()
val.back()
Contributor
Author
There was a problem hiding this comment.
Thanks for the tips! Looks good on the CI.
2 tasks
In the case of the value contains whitespaces, it has to be surrounded with quotes (single or double). We should exclude these characters from the final values. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
b9b2c44 to
db448f9
Compare
krnowak
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally tested with
update_engine_client -check_for_updatethen inspecting the request/response.Before adding the patch, I added test cases that fails with:
Flatcar CI here: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2725/cldsv/