Stop probing for UUID 00000000-0000-0000-0000-000000000001 in GRUB#82
Merged
margamanterola merged 1 commit intomainfrom Aug 4, 2020
Merged
Stop probing for UUID 00000000-0000-0000-0000-000000000001 in GRUB#82margamanterola merged 1 commit intomainfrom
margamanterola merged 1 commit intomainfrom
Conversation
This was referenced Jul 23, 2020
5876c4e to
9fd35d6
Compare
Contributor
Author
|
This has now been fully tested as mentioned in flatcar/bootengine#17 |
9fd35d6 to
c832af0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop probing for UUID 0x01 in GRUB
Our GRUB configuration is currently probing all devices in search of a device with UUID 00000000-0000-0000-0000-000000000001. This is causing trouble on Packet c3.medium.x86 and m2.xlarge.x86 machines, where this probing leads to the machine hanging on GRUB for almost half an hour and then not mounting the disks correctly. See flatcar/Flatcar#155 for more information.
This code removes the probing from GRUB. An equivalent check will be added to bootengine to be performed during initramfs.
How to use / Testing done
Building an image with this change leads to GRUB booting successfully on a c3.medium.x86 machine. Without the corresponding bootengine change, the disk UUID stays at 0x01. With the corresponding change, it gets randomized after initramfs is done running.
WIP notice: Due to issues with current flatcar-master-alpha, I wasn't yet able to fully test this change on all platforms, I only manually tested it on Packet. Once alpha is fixed, I'll test again on all platforms.