sys-kernel/coreos-modules: Enable Netkit flag#3524
Conversation
fc75bc9 to
9c42188
Compare
sdk_container/src/third_party/coreos-overlay/sys-kernel/coreos-modules/files/commonconfig-6.12
Outdated
Show resolved
Hide resolved
Closes flatcar/Flatcar#1959 Signed-off-by: Tim Buchwaldt <tim.buchwaldt@deepl.com>
|
Images are available here: https://github.com/flatcar/scripts/actions/runs/19855010770?pr=3524 and netkit is enabled: Two tests are failing but it's unrelated (because the PR comes from a fork). @timbuchwaldt any chance to try the provided images? |
|
Will this make our Cilium tests more reliable? 🤔 |
Not really, it seems it has to be explicitely opt-in. What we can do is to add a variant to our Cilium Kubernetes tests to test netkit, similar to this: https://github.com/flatcar/mantle/blob/c4e298d8328977f03869d2f73ddd4c61cc836a0d/kola/tests/kubeadm/kubeadm.go#L50-L54 |
|
Currently out sick from work, will have a look at testing once back |
Hey, the images are now back here: https://github.com/flatcar/scripts/actions/runs/19855010770 (thanks @chewi for triggering the builds) |
|
I finally managed to play with it a bit, and netkit works! From my side this is good to go! |
Enable Netkit flag
Enable the netkit config flag, closes flatcar/Flatcar#1959
How to use
Load netkit module, enjoy Cilium performance improvements.
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.